Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RequestReply types and CRD #8337

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: add RequestReply types and CRD #8337

merged 2 commits into from
Nov 21, 2024

Conversation

Cali0707
Copy link
Member

Fixes #8177

Proposed Changes

  • Add RequestReply v1alpha1 CRD
  • Add RequestReply types (Spec, Status, etc.)
  • Add RequestReply validation/defaulting/lifecycle code

Release Note

Added the RequestReply CRD and types (no controller/data plane implementation yet)

@knative-prow knative-prow bot requested a review from aslom November 21, 2024 02:07
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 21, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @creydr @matzew

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@Cali0707 Cali0707 changed the title feat: add requestreply types and CRD feat: add RequestReply types and CRD Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.09434% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ebe99e6). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../apis/eventing/v1alpha1/requestreply_validation.go 35.71% 19 Missing and 8 partials ⚠️
...g/apis/eventing/v1alpha1/requestreply_lifecycle.go 79.48% 8 Missing ⚠️
pkg/apis/eventing/v1alpha1/requestreply_types.go 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8337   +/-   ##
=======================================
  Coverage        ?   64.53%           
=======================================
  Files           ?      380           
  Lines           ?    22772           
  Branches        ?        0           
=======================================
  Hits            ?    14697           
  Misses          ?     7300           
  Partials        ?      775

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

pierDipi
pierDipi reviewed Nov 21, 2024
View reviewed changes
pkg/apis/eventing/v1alpha1/requestreply_defaults.go

func (rrs *RequestReplySpec) SetDefaults(ctx context.Context) {
if rrs.Timeout == nil || *rrs.Timeout == "" {
rrs.Timeout = ptr.To("30s")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could make this globally configurable in the features flag config map

pierDipi
pierDipi approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5ad7dab into knative:main Nov 21, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aslom aslom Awaiting requested review from aslom

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@creydr creydr Awaiting requested review from creydr

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestReply: Create API types
2 participants
@Cali0707 @pierDipi